Proposed fix for #396: Implement propertyNames in terms full schema validation #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
============================================
- Coverage 70.68% 70.60% -0.09%
+ Complexity 753 744 -9
============================================
Files 81 81
Lines 2900 2885 -15
Branches 596 589 -7
============================================
- Hits 2050 2037 -13
+ Misses 628 627 -1
+ Partials 222 221 -1
Continue to review full report at Codecov.
|
- implement property names in terms of full schema validation - add test case for complex property name - added test case for networknt#342 - fix networknt#375 tests to expect standard messages - closes networknt#396 - closes networknt#342
JonasProgrammer
force-pushed
the
proposal/396-property-names-as-schema
branch
from
28fd498 to
d61d006
Compare
|
@JonasProgrammer Nice fix!!! It was my mistake in the initial implementation due to the limited understanding of the document and the test cases. Thanks a lot for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.